-
Notifications
You must be signed in to change notification settings - Fork 1.4k
⚠️ Drop revisionHistory in MachineDeployment #12274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Drop revisionHistory in MachineDeployment #12274
Conversation
WIP => needs rebase after #12262 is merged |
5077a89
to
7207195
Compare
/test pull-cluster-api-e2e-main |
7207195
to
6dd8a8e
Compare
/test pull-cluster-api-e2e-main |
// revisionHistoryAnnotation maintains the history of all old revisions that a machine set has served for a machine deployment. | ||
// | ||
// Deprecated: This annotation is deprecated and is going to be removed in the next release. | ||
const revisionHistoryAnnotation = "machinedeployment.clusters.x-k8s.io/revision-history" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This annotation will be removed in a follow-up (tracked in #10852)
Main goal of this PR is to drop the user-facing revision history feature
/lgtm /retest Flake?
|
LGTM label has been added. Git tree hash: 975dd6c1aa0bf9ed86693b6ee5baa0599a2e2214
|
6dd8a8e
to
52c5329
Compare
/test pull-cluster-api-e2e-main |
Had to rebase because of conflict in golangci-lint config file |
@@ -127,7 +127,8 @@ proposal because most of the changes described below are a consequence of the wo | |||
- Support for terminal errors has been dropped. | |||
- `status.failureReason` and `status.failureMessage` will continue to exist temporarily under `status.deprecated.v1beta1`. | |||
- The const values for `Failed` phase has been deprecated in the enum type for `status.phase` (controllers are not setting this value anymore) | |||
- The `status.phases` field is now computed using the same logic used for `ScalingUp` and `ScalingDown` conditions. | |||
- The `status.phases` field is now computed using the same logic used for `ScalingUp` and `ScalingDown` conditions. | |||
- The `spec.revisionHistoryLimit` field has been removed. The MachineDeployment controller will now clean up all MachineSets without replicas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you don't mind, let's also document that the machinedeployment.clusters.x-k8s.io/revision-history annotation is removed and remove the annotation from https://cluster-api.sigs.k8s.io/reference/api/labels-and-annotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
9e4d665
to
cf31baa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Nice!
Revision history existed since when MD where copied from Deployments, but we never nailed down implications (e.g. downgrades), and, as we discovered when bringing up this topic at the office hours, it looks like that with ClusterClass and GitOps folks stopped caring.
LGTM label has been added. Git tree hash: 71b215a156bed9f6f105eb6175b530cac1335399
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10479
Part of #10852